Added status message area to USB connect workflow #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed some catching of exceptions inside the workflow to catch at outer function so we can report. - Added an element to the dialog to hold status messages. - Catch and analyze exceptions to print user friendly messages if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to provide user friendly feedback during the USB connection using WebSerial and selecting a filesystem mount point.
I worked on this PR when noticing some hiccups when trying to connect my microprocessor via USB. See #327, although it's not a great solution to the read-only issue as the element I created to show status isn't visible after the connect part of the workflow finishes.